Closed AbhiPrasad closed 9 months ago
db.name
applies to Mobile SDKs as well, added the Mobile label.
We've updated https://develop.sentry.dev/sdk/performance/span-data-conventions/#database to better reflect the new attributes we are setting here.
Opened https://github.com/getsentry/sentry-java/issues/2930 as a follow up but does not block the starfish DB module so closing this issue.
Project Board
To get an overview of this work across all SDKs, please visit: https://github.com/orgs/getsentry/projects/135
Description
For the starfish db module it was determined that we need extra database attributes, specifically about the database connection attributes.
We're going to matching the otel db conventions. Either one of
server.address
orserver.socket.address
is required. Ifserver.address
is set, thenserver.port
should be set. Ifserver.port
is different thanserver.socket.port
, thanserver.socket.port
should also be set. In addition,db.name
should be set if possible.db.system
should match the list in OpenTelemetry's well known conventions.The main priority items are
db.name
anddb.system
db.system
mysql
db.name
customers
;main
server.address
example.com
server.port
80
;8080
;443
server.socket.address
10.5.3.2
server.socket.port
16456
server.port
.These values should be set on
span.data
.NOTE: For the Mobile SDKs only
db.name
anddb.system
is requiredRFC
No response
Slack-Channel
discuss-starfish
Notion Document(s)
No response
Stakeholder(s)
@alexjillard and @gggritso
Team(s)
Web Backend, Web Frontend, Starfish