search

getsentry / team-sdks

A meta repository for tracking work across all SDK teams.
0 stars 0 forks source link

Protocol: Send envelope types with requests #73

Open mwarkentin opened 3 months ago

mwarkentin commented 3 months ago

Description

We currently have no visibility into the type of event that we are dealing with in any of our systems before we hit relay. These are mainly the Google load balancer and our anti-abuse PoP layers.

An example of this issue came up in INC-648, where there are submitted events receiving errors from the GLB and never making their way to our backend systems. It's difficult to understand what type of events are running into these issues.

RFC

No response

Slack-Channel

#inc-648

Notion Document(s)

INC-648 doc

Stakeholder(s)

INC-648, SRE

Team(s)

No response

sl0thentr0py commented 3 months ago

questions

AbhiPrasad commented 3 months ago

is this a new http header?

We can also send as a query param, this feels like an implementation detail so I edited the issue accordingly.

i assume we just take the first item type if the envelope has multiple items

Yup first envelope item seems safest to send

mwarkentin commented 3 months ago

@AbhiPrasad I wonder if it would be possible to make this a (comma-separated?) list or array of types if there are multiple items? I'm not sure how common it is for multiple types to be grouped together or not.