getsentry / team-sdks

A meta repository for tracking work across all SDK teams.
0 stars 0 forks source link

Remove `enableTracing` #84

Open HazAT opened 6 months ago

HazAT commented 6 months ago

Currently, we offer multiple options to configure sampling for tracing:

But when to use which, is sometimes not obvious to our users. What makes this worse is that implications of some of them differ across SDKs, for example when it comes to Trace Propagation. In Python for example, propagation of trace headers works without any tracing config options in place being set. In Go, you need to at least set enableTracing to true in order to achieve the same result.

Goal is:

Deprecation

## SDKs
- [ ] https://github.com/getsentry/sentry-javascript/issues/12883
- [ ] https://github.com/getsentry/sentry-dart/issues/2181
- [ ] https://github.com/getsentry/sentry-cocoa/issues/4177
- [x] PHP SDK https://github.com/getsentry/sentry-php/pull/1743
- [x] Laravel SDK https://github.com/getsentry/sentry-php/pull/1743
- [ ] React Native SDK (via JS https://github.com/getsentry/sentry-javascript/issues/12883)
- [ ] https://github.com/getsentry/sentry-java/issues/3566
- [x] ~Kotlin Multiplatform SDK~
- [x] ~~Native SDK~~
- [ ] Electron SDK
- [ ] Python SDK
- [ ] Symfony SDK
- [ ] Go SDK
- [ ] Ruby SDK
- [ ] Elixir SDK
- [ ] Rust SDK
- [ ] .NET SDK
- [ ] Unity SDK
- [ ] Unreal SDK
- [ ] PowerShell SDK
- [ ] Android SDK (via Java SDK)
- [ ] Capacitor SDK
- [ ] Cordova SDK
- [ ] Sentry CLI
cleptric commented 6 months ago

I don't see an issue with the naming here, what makes tracesSampleRate not apply to a span vs a transaction? We'll always need some sort of rates user's can apply.

krystofwoldrich commented 4 months ago

RN will get this from JS.