getsentry / unity-docker

Docker container for Unity CI
2 stars 2 forks source link

Automation suggestion #1

Open bruno-garcia opened 2 years ago

bruno-garcia commented 2 years ago

A GHA workflow that runs on a schedule and checks Unity's release page for new releases: https://unity3d.com/unity/whats-new/

If a release came out, it creates a PR in this repo bumping the version in the yml file:

https://github.com/getsentry/unity-docker/blob/e7c50834ccfb0aad7029158a24a8cb5719e284db/.github/workflows/ci.yml#L26-L33

It would need to make sure it won't open a PR if one exists (regardless of its state (merged, open or closed)

vaind commented 2 years ago

There's very likely an API, assuming Hub doesn't parse the pages. I'll first check that.

vaind commented 2 years ago

I've had a look at this and would suggest the following:

bruno-garcia commented 2 years ago

Makes sense. Seems like #2 is missing the scheduling We need to make sure CI on the unity repo doesn't bump to latest automatically though, because, for example, 2019.4.36f (the latest) is broken, so that would stop all of our CI workflows. Ideally a PR would be opened everyday a new Docker image is created bumping not only the docker image there, but also the versions we used in Windows and macOS (e.g: https://github.com/getsentry/sentry-unity/pull/567)

vaind commented 2 years ago

Makes sense. Seems like #2 is missing the scheduling

Wanted to hear your thoughts first before doing that change. Now that I have, I'll update the CI.

We need to make sure CI on the unity repo doesn't bump to latest automatically though, because, for example, 2019.4.36f (the latest) is broken, so that would stop all of our CI workflows. Ideally a PR would be opened everyday a new Docker image is created bumping not only the docker image there, but also the versions we used in Windows and macOS (e.g: getsentry/sentry-unity#567)

Yep, makes sense. Didn't want to do auto-update-to-latest in sentry-unity, just here