search

getsentry / uptime-checker

Service responsible for powering Sentry's uptime detection features
Other
3 stars 2 forks source link

ref: Sanitize generic failure error message url #174

Closed evanpurkhiser closed 2 months ago

evanpurkhiser commented 2 months ago

If the URL included a token or something we wouldn't sanitize it, let's avoid including the URL

evanpurkhiser commented 2 months ago

Yeah, it doesn't look like we actually do any logging though 🙃

wedamija commented 2 months ago

Yeah, it doesn't look like we actually do any logging though 🙃

We log the result somewhere, I'm pretty sure I've used this url being part of the results to help figure things out in logs

evanpurkhiser commented 2 months ago

Oh, this just removes it from the error though