Closed mydea closed 12 months ago
Attention: 14 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
app/models/category.server.ts | 83.33% <6.66%> (-16.67%) |
:arrow_down: |
:loudspeaker: Thoughts on this report? Let us know!.
Remove unneeded package-lock.json (we are using pnpm here)
Broke GCP build because:
I'll try to remove that and we'll see (not sure how pnpm work) if that does it
While trying to get this to run from scratch, I noticed some things with the readme/setup docs, so I figured I'd update everything to make sure it's easy to run this:
pre-commit
SENTRY_PROJECT
into example.env
+ update to recommend org auth tokenspnpx
, just usenpx
(pnpx didn't work for me, I guess I'd need some more pnpm setup for this, but probably npx is just fine here)npx prisma db seed
?? (this complained that there is no seed configured, not sure if I missed this somehwere?)