getsentry / vanguard

Apache License 2.0
41 stars 3 forks source link

feat: Update Remix and Moment libraries #16

Closed dcramer closed 2 years ago

dcramer commented 2 years ago

The Remix upgrade has a pretty big change to the file uploads API, and the GCS handler still needs tested (we're doing it live!). If it fails in prod we'll revert and I'll work on getting a QA env up.

The main things to know:

1) you must have a composable handler with the inmemory handler being the last item. without this the form data never gets populated for other fields.

2) mimetype has become contentType in file filters

3) the return value of upload handlers needs to be non-false otherwise they continue to the next handler. this causes the file uploads to be have oddly if no value is present.