search

getsentry / vanguard

Apache License 2.0
41 stars 3 forks source link

Reacji counts not updated when switching between posts using "Recent Posts" #39

Closed mwarkentin closed 2 years ago

mwarkentin commented 2 years ago

Steps to Reproduce

  1. Open a post, scroll down, check out reaction counts
  2. Click on another post in "Recent Posts" list
  3. Scroll down, see identical reaction counts

Expected Result

I thought I would see the correct reaction count for the 2nd post viewed.

Actual Result

vanguard-reacji-counts

dcramer commented 2 years ago

Im convinced this is a Remix bug, that I'm not actually sure how we're supposed to solve. Its your typical React re-render issue, that you'd normally force re-render on parent route change, but we dont actually manage that within Remix.

chadwhitacre commented 2 years ago

File with Remix?

dcramer commented 2 years ago

Lets see if this resolves it: https://github.com/getsentry/vanguard/commit/0274b78adf9602c78c435f09a29db9308ce9ce41

I think its an issue with equality tests

chadwhitacre commented 2 years ago

Confirmed working now. 👍