search

getsentry / vanguard

Apache License 2.0
41 stars 3 forks source link

fix: Layer the primary content above the sidebar background #62

Closed ryan953 closed 2 years ago

ryan953 commented 2 years ago

The layers stack up when the window is about 1025px wide to 1200px.

Before After
Screen Shot 2022-08-17 at 2 09 42 PM Screen Shot 2022-08-17 at 2 09 31 PM

Ultrawide monitors at home could work, but then i'd need a bigger desk + bigger room and in SFO that's crazy.

ckj commented 2 years ago

@ryan953 I think my math might just be wrong on the right padding (or margin) of the primary column. I think fixing that should fix this

ryan953 commented 2 years ago

I think my math might just be wrong on the right padding (or margin) of the primary column. I think fixing that should fix this

@ckj You mean the breakpoint maths/padding? Could be something like that.

Personally I think overlap is cool and the problem was only just apparent at that specific window size

edit: i wrote 1800px originally, it's actually just between 1025px to about 1200px. idk where 1800 came from