search

getsidetrack / swiftui-pipify

A SwiftUI component for launching custom picture-in-picture experiences
MIT License
155 stars 14 forks source link

Size classes #17

Open jordibruin opened 2 years ago

jordibruin commented 2 years ago

Maybe we should return if the pip window is small, medium or large instead of just the value? Since it will depend on the ratio compared to the screen, and that will change based on how large the view etc is.

Sherlouk commented 2 years ago

Sounds like an interesting idea!

I'm curious on the math that you're proposing here though because in my testing there doesn't always seem to be 3 different sizes that it can even scale to. In fact, I've had it on my phone where you can't change the size (so is that the smallest or largest? it's both 😂).

This is also technically something clients can implement themselves if they have custom business logic by extending the DockableController.

jordibruin commented 2 years ago

Maybe we could pass the frame of the view through to the dockableController and based on that we can determine the relative size?