search

getsidetrack / swiftui-pipify

A SwiftUI component for launching custom picture-in-picture experiences
MIT License
155 stars 14 forks source link

Made README a little bit clearer by including the StateObject #19

Closed jordibruin closed 2 years ago

jordibruin commented 2 years ago

Not perfect yet, but better than what we have now.

Sherlouk commented 2 years ago

Hey Jordi!

Thanks for the PR - spoken to you briefly externally but thought I'd summarise here for transparency.

The sample code provided here is no longer the expected implementation - in fact, this code would not compile as you can no longer initialise the PipifyController.

I do agree however that we absolutely need to improve documentation to include a more thorough example showing the @State parameter which is provided to the pipify modifier.

I'll pick this up in a quick PR.

Sherlouk commented 2 years ago

Closed by 4050d5645493088cbe04f1714ab09c331e6507bb