search

getslash / slash

The Slash testing infrastructure
https://getslash.github.io/slash
Other
75 stars 38 forks source link

Investigate fail tests of test_slash_resume.py #1072

Open ayalash opened 1 year ago

ayalash commented 1 year ago 
FAILED tests/test_slash_resume.py::test_failed_first_or_unstarted_first[False] - AssertionError: assert 'test_00187' == 'test_00185'
FAILED tests/test_slash_resume.py::test_failed_only_or_unstarted_first[False] - AssertionError: assert 'skipped' == 'planned'
ayalash commented 1 year ago

The tests start failing with the merge of: https://github.com/getslash/slash/pull/1068

https://github.com/getslash/slash/actions/runs/4842958840/jobs/8630233783

oren0e commented 1 year ago

Do you want me to take a look?

oren0e commented 1 year ago

@ayalash for the second test that fails, I think that this is because the test sets "unstarted_only" and with my change it can mean two things - planned or skipped. See https://github.com/getslash/slash/blob/develop/slash/resuming.py#L194:L196

ayalash commented 1 year ago

Hey @oren0e, Sorry for the late response. Thanks for taking a look, I'll get to check what you later today and get back to you.