search

getslash / slash

The Slash testing infrastructure
https://getslash.github.io/slash
Other
75 stars 38 forks source link

Simplify dependency specification for ipython #1078

Closed gragib closed 1 year ago

gragib commented 1 year ago

I have had many issues with resolving dependencies in projects that use poetry or pdm. ipython 1.2.1 is used when installing slash in Python 3.7+ on Windows/Ubuntu/macOS. The changes proposed in this PR should preserve the current behaviour when using pypy, while allowing cpython implementations to use more recent versions of ipython.

vmalloc commented 1 year ago

I don't think this change preserves the current behavior, as it unpins the dependency for pypy. Am I wrong?

gragib commented 1 year ago

Moving this to draft while I gather the evidence.

gragib commented 1 year ago

Is there any particular reason why ipython is pinned to 1.2.1 for pypy?

gragib commented 1 year ago

Closing this since I can't even get the wheels on PyPI to install in pypy.