Ensure that repository removal functionality works and is hooked up to ferryctl

[ermo]

DeleteRepo pops up one time too many in a rg DeleteRepo search to be "not yet implemented" as one comment says in ferryd/core/repo.go.

We need this functionality for easy testing of the epoch bump where we need to be able to do quick successive cycles of create/index/remove <the epoch testing repo>.

[livingsilver94]

Are you sure that's not a stale comment? This sequence of commands works:

mkdir bin/myRepoBase
./bin/ferryd -d bin/myRepoBase -s ./ferryd.sock &
./bin/ferryctl -s ./ferryd.sock create-repo testing
# bin/myRepoBase/repo/testing has content
./bin/ferryctl -s ./ferryd.sock remove remove testing
# bin/myRepoBase/repo/testing is now gone

Yeah, remove remove is awkward :P

[ermo]

Are you sure that's not a stale comment? (...)

No, I'm not. Hence why I tasked you domain experts to take a better look at it? Which (by the look of things) is already paying off...?

cc: @joebonrichie

[livingsilver94]

Ok so, the core API is working according to my test, plus so is the ferryctl invocation. The HTTP API remains to be tested then.

[ermo]

Ok so, the core API is working according to my test, plus so is the ferryctl invocation. The HTTP API remains to be tested then.

Any chance we could rename the command-line invocation to remove-repo perhaps...?

So ./bin/ferryctl -s ./ferryd.sock remove-repo testing for instance?

[livingsilver94]

Shouldn't be hard at all!

[livingsilver94]

This works: curl --unix-socket /path/to/ferryd.sock http://localhost/api/v1/remove/repo/testing

So yeah, it's definitely a stale comment. Gonna implement what you requested.