getsolus / packages

Solus Package Monorepo & Issue Tracker
65 stars 81 forks source link

new macros for cargo does not accept more then one binary #3230

Closed androidnisse closed 1 month ago

androidnisse commented 3 months ago

Please confirm there isn't an existing open bug report

Summary

When using %cargo_install it only accepts one binary. If more is needed a loop or using the macro multiple times is needed. See example in https://github.com/getsolus/packages/pull/3229/files

Steps to reproduce

  1. Build with more then one binary

Expected result

It installs all.

Actual result

It fails and falls backs to the package name.

Environment

Repo

Unstable

Desktop Environment

Budgie

System details

x

Other comments

Posted about this in package room on matrix.

EbonJaeger commented 3 months ago

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

androidnisse commented 3 months ago

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

I have found this once for now. This can be looked at further when all packages use the macro.

Will add what I find here: https://github.com/getsolus/packages/pull/3234/files https://github.com/getsolus/packages/blob/main/packages/j/juliaup/package.yml https://github.com/getsolus/packages/blob/main/packages/p/pueue/package.yml

androidnisse commented 3 months ago

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

Seems to be 4, see above comment. :)

Staudey commented 3 months ago

Would also save one line in ripgrep-all ^^ https://github.com/getsolus/packages/blob/2a91e453f4b6897b3dbbcb50b90443bac311794e/packages/r/ripgrep-all/package.yml#L25-L26

androidnisse commented 3 months ago

Would also save one line in ripgrep-all ^^

https://github.com/getsolus/packages/blob/2a91e453f4b6897b3dbbcb50b90443bac311794e/packages/r/ripgrep-all/package.yml#L25-L26

Good catch 👍