malfisya
commented
12 months ago Hello, i want to try to help with this one. A few question:
- I see in the example given it just says
Copyright 2023 Solus Developers <copyright@getsol.us>, while in commit https://github.com/getsolus/packages/commit/8b48034963aa8dfb329a96ef5ebfe1b1c089252d it saysCopyright 2014 Richard Hughes <richard@hughsie.com>. Where does the copyright info should come from? - info provided inside
metainfo.xmlonfont-clear-sans-ttfdoesn't really match with the specs given in the example. Also the filename should beclear-sans.metainfo.xml. Should i also add pull request for this? - Is
homepageshould also be included insomefont.metainfo.xml?
joebonrichie
TraceyC77
Add appstream metainfo to all font packages so font previews show up in Software Centers.
Please see
font-clear-sans-ttfin the Solus Software Center as an example.Please see this commit for
liberation-fonts-ttfon how to add appstream metainfo to a packagehttps://github.com/getsolus/packages/commit/8b48034963aa8dfb329a96ef5ebfe1b1c089252d
Finding fonts to update
Originally, all of our fonts except
font-clear-sans-ttfandliberation-fonts-ttfwere missing appstream data. To search for fonts that have no metainfo.xml file:Method 1: Run this (substitute solus-builds for the directory you have on your system):
Also check t/texlive/files for the texlive fonts
Note: Make sure the package is actually a font. The above commands are provided for convenience.
Method 2: Run this to find all desktop font packages:
eopkg info -c desktop.fontThen pick a font and check its info in the repo. Pick one that has no metadata file to add appstream data to.
Create the metainfo file
Create a file
fontname.metainfo.xmlin thefilessubdirectory (for the liberation-fonts-ttf font this file is namedfiles/liberation.metainfo.xmlbecause the font name isliberation) It should containYou will need a few pieces of data for the file for the placeholders.
eopkg info fontname | grep Namefor idinstallsection of itspackage.ymlfile. The font name is the last part of the directory in the install directive.package.yml, if not please add it as part of your commit.If the font provides translations for the name, add them like this:
See this PR for reference.
Then install it via
package.ymlBuild and test
To test the appstream metainfo is valid; after building the package with the appstream data included
Install
appstream-glibthen runappstream-builder --packages-dir=. --include-failed -vFinally, check that the package doesn't show up in the
example-failed.xml.gzfile. The font preview will then show up in the software center whenappstream-datais next refreshed.To cleanup after running appstream-builder, run:
rm -fr example* tmp/ cache/.If a font package provides more than one font
appstream-builderrequires a 1:1 mapping between appstream data and packages. If a package provides several different families of fonts, it must also be sub-packaged if providing more than one appstream metainfo xml file.If a font is sub-packaged you can use the
extendsfield in its metadata file so that one font extends another e.g.In the
package.ymlfile only use one install directive for the metainfo file for the parent. Use patterns to put the sub-package metainfo.xml files in the right place. Example from noto-sans, which has noto-serif as a sub-package:Further information
Reference: The Freedesktop font metadata spec