Go modules - Githubissues

getsolus / solbuild

The Solus package build system

https://getsol.us

Apache License 2.0

21 stars 12 forks source link

Go modules #9

Closed livingsilver94 closed 3 years ago

livingsilver94 commented 3 years ago

Removed git submodules in favor of Go modules
Moved src/ content to the root, as it is idiomatic in Go projects
Swapped some libraries forked by Josh with their upstream versions
Updated github.com/cheggaaa/pb to v3. Some API changed, so I updated the code. No aesthetic edits were deliberately made. The library changed how it renders the bar though.
Simplified the Makefile
Updated the copyright strings

livingsilver94 commented 3 years ago

My PR leaves the README in a wrong state. Should I update it too?

livingsilver94 commented 3 years ago

JoshStrobl commented 3 years ago

With regards to my fork, that won't be necessary thanks to:

Go vendors
The dedicated v28 branch for 0.28.x support.

My fork was performed to introduce fixes that eventually landed upstream, so I can drop that in favor of upstream and we can work on moving it away from 0.28 (solbuild is really only ever the blocker for libgit2 update).

I agree that the use of goimports instead of gofmt + our typical ordering is a regression and should be reverted.

livingsilver94 commented 3 years ago

I sold my soul to the devil and used gofmt to sort imports.

DataDrake commented 3 years ago

LGTM. Thanks!

getsolus / solbuild

Go modules #9

Updated github.com/cheggaaa/pb to v3. Some API changed, so I updated the code. No aesthetic edits were deliberately made. The library changed how it renders the bar though.

Simplified the Makefile

Updated `github.com/cheggaaa/pb` to v3. Some API changed, so I updated the code. No aesthetic edits were deliberately made. The library changed how it renders the bar though.