search

getsolus / ypkg

Modern, declarative, structured build format
https://getsol.us
GNU General Public License v3.0
22 stars 11 forks source link

ypkg2: Only enable fakeroot during the install & check steps #36

Closed joebonrichie closed 1 year ago

joebonrichie commented 1 year ago

This will only allow $installdir to be used during install and check steps. (Though, packagers should only be using it during install.)

This is extremely desirable due to the extreme overhead of fakeroot. Especially when ccache is enabled but there are no cache hits for a build.

silkeh commented 1 year ago

Small suggestion: why not make the flags a fakeroot setting with an of array of stages to enable it for (defaulting to [install, check]). That would increase the flexibility a bit, although I'm not entirely sure about the usefulness.

joebonrichie commented 1 year ago

Nice idea but not sure about the usefulness. Approaching this from the perspective from the average packager where if they run into trouble they just need to set one option.