search

getsops / sops

Simple and flexible tool for managing secrets
https://getsops.io/
Mozilla Public License 2.0
16.58k stars 865 forks source link

3.9.0: RPM package name changed again #1547

Open felixfontein opened 3 months ago

felixfontein commented 3 months ago

The RPM packages had a -1 after the version before the 3.8.0 release (https://github.com/getsops/sops/issues/1266#issuecomment-1693345800), which wasn't there anymore for 3.8.x. But now with 3.9.0 it's back:

sops-3.9.0-1.aarch64.rpm
sops-3.9.0-1.x86_64.rpm

(https://github.com/getsops/sops/releases/tag/v3.9.0)

This is extremely frustrating for automated consumers of the releases such as the Ansible community.sops release, since this again broke its SOPS installation step.

Is there a way to fix the filename format somehow so it won't change again in the future?

felixfontein commented 3 months ago

My guess that this is related with updates to goreleaser, so I would suggest to add a test which runs regularly (maybe weekly, just to make sure it still works) and when the release workflow is updated (which happens if the goreleaser version used in the release process is updated) to run goreleaser and check the output filenames.

That way we find out ealier whether a goreleaser update breaks something, and we can investigate before releasing...

felixfontein commented 3 months ago

The behavior changed in nFPM 2.33.1 (https://github.com/goreleaser/nfpm/releases/tag/v2.33.1; more precisely: https://github.com/goreleaser/nfpm/pull/715), which was included in goreleaser 1.21.0 (https://github.com/goreleaser/goreleaser/releases/tag/v1.21.0), which we switched to in https://github.com/getsops/sops/pull/1427/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R68 - the PR assumed that version: 1.20.x was the Go version, and not the goreleaser version, so this change happened unnoticed when #1427 got merged.