getstation / desktop-app

One app to rule them all!
https://getstation.com/
Apache License 2.0
1.44k stars 206 forks source link

Setting for opening links #178

Open stkjj opened 1 year ago

stkjj commented 1 year ago

right now Station opens a link in a seperate window of it's own. Right click allows additionally for "Open Link in new page" and "Open Link in default browser":

Bildschirmfoto  2023-07-07 um 11 01 38

An additional setting to chose any of these as default behavior (esp. with the link being opened in the background without leaving Station) would be helpful to gather info in Station from various sources and to dive deeper later in open browser tabs.

NithyaMenon commented 1 year ago

I was just going to raise the same issue,+1 on this 👍

libroraptor commented 1 year ago

Another +1 from me. Also ctrl-click or cmd-click to open in the not-usual browser.

sanyatuning commented 1 year ago

The default browser should be the default action, settings for this should be an addition.

ebisbe commented 1 year ago

I was also looking for this. The app is awesome but I need to use the default browser

rloechner commented 1 year ago

+1 for this feature to be added.

ericgoetz commented 1 year ago

+1 Opening links within Station instead of the default browser seems counter to their design philosophy. In any case, I want all links to be opened within the default browser. Unlike the OP, however, I want the browser to come to the front and steal focus when I click on a link.

libroraptor commented 1 year ago

I think that we might benefit from a config pref:

k-r-chandran commented 1 year ago

+1 to this--an option to open links directly in the default browser would be really helpful here

samwh1te commented 1 year ago

+1 !!!

NSDodgers commented 1 year ago

Yes please! +1

wei-lin-lee commented 1 year ago

+1 Please as Station is a very good multi tasking app but without default browser opening it actually hinders the multi tasking at work.

viktor44 commented 1 year ago

Since Station 2.5.0 you can use Ctrl+Click (MacOS: Cmd+Click) to open a link in default browser and Shft+Click to open a link in background browser tab.

NSDodgers commented 1 year ago

it would be very nice if it could be set as default.

viktor44 commented 1 year ago

@NSDodgers what could be set?

NSDodgers commented 1 year ago

Opening links in the default browser by default without an extra key modifier — Nick Solyom (he / him / his) 818 822 7156 @.***

On Thu, Oct 12, 2023 at 9:10 AM Viktor @.***> wrote:

@NSDodgers https://github.com/NSDodgers what could be set?

— Reply to this email directly, view it on GitHub https://github.com/getstation/desktop-app/issues/178#issuecomment-1759586016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAWS5XP4CHZ5L6DYPQNYGDX67T4FAVCNFSM6AAAAAA2BPCVS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJZGU4DMMBRGY . You are receiving this because you were mentioned.Message ID: @.***>

Th3CodeFather commented 1 year ago

+1 this would make Station a dream app!

Lindsor commented 1 year ago

This actually causes issues with a lot of integrations. Gmail attachments (Open with drive), Discord links...

Theres a lot of these that just don't seem to work on station because default is that little InAppBrowser

viktor44 commented 1 year ago

@Lindsor try https://github.com/getstation/desktop-app/issues/178#issuecomment-1759215072 Works perfect for me.

Lindsor commented 1 year ago

@viktor44 it works with a few links which is really nice but not all like these:

image

I cant show the entire screen but its a gmail word attachment to open in google drive

k-r-chandran commented 1 year ago

If we were offered an option to set a default, then some users who prefer the in app browser can choose to keep it. It seems to me that there are many uses for which this would be useful, but there are many times this adds confusion. The example above with Google Drive comes up quite often. Zoom links often create issues as well.

viktor44 commented 1 year ago

@Lindsor I got it. You're right. It is a problem.

Unfortunately, this feature is not easy to implements.

joshuadutton commented 8 months ago

@viktor44 I've look at the source code to try and figure this out, but I don't see where to implement this yet. You say it's not easy, so I'm guessing that it's not as simple as modifying one of the click callbacks. Can you give me a bit more direction of what it would take to implement it so I can decide if I want to take it on?

This is only thing that bothers me about using Station. While there are other options like the right-click menu and Ctrl+Click (MacOS: Cmd+Click), I find that 90% of the time I forget to do this on the first try because my brain has been trained by all the other apps that I use.

viktor44 commented 8 months ago

@joshuadutton it would be great if you tried to implement this. Actually I don't know how to do it 😄

Here https://github.com/getstation/desktop-app/blob/817ed93511e976c128fb851a908ed812401ee7a3/app/services/services/tab-webcontents/main.ts#L270

we are playing with the way of opening new window. Maybe it's now the right place to address the issue, but it's a good point to start the investigation.

2ge commented 5 months ago

+1 from me. It is really nagging me that by default Station is using own window, half things doesnt work there (PDF preview, sessions are not shared...). By default it should open in default browser, and in setting one can choose...it could be in theory per app settings, some apps I believe is ok to have it as it is now...but most of them nope.

Litwilly commented 1 week ago

+1 on using default browser as a default.

Gauchoref commented 5 days ago

Trying to decide which platform to migrate to replace Franz. Love my trial with Station but this one issue may be a deal-breaker

joshuadutton commented 5 days ago

I'm currently using Vivaldi browser as a replacement. I've setup my frequently used apps (like email) as "web panels" and it works quite well.