getstation / desktop-app

One app to rule them all!
https://getstation.com/
Apache License 2.0
1.41k stars 206 forks source link

Enabling nodeIntegration + Electron 27 #367

Closed viktor44 closed 5 months ago

viktor44 commented 5 months ago

What is this PR

1) nodeIntegration is enabled for Webview. 2) contextIsolation is enabled for Webview. It is necessary because otherwise otherwise huge part of apps don't work. 3) as a result of (2), integration with window.bx is rewritten with contextBridge (see) 4) Electron is upgraded up to 27 (maybe it's better to move to separate PR, but it doesn't require any changes in code now)

Thank you @magne4000 for research in PR

magne4000 commented 5 months ago

LGTM, nice works!