getstation / electron-chrome-extension

Implementation of Chrome extension APIs for Electron
139 stars 26 forks source link

Grammarly #11

Closed alexstrat closed 5 years ago

alexstrat commented 6 years ago

Extension id: kbfnbcaeplbcioakkpcpgfkobkghlhen Chrome Webstore

alexstrat commented 6 years ago

With electron 1.7.8 ❌

The Grammarly icon does not show, and no error in console but errors in the background page

With electron electron/electron#11131 and #6 ❌

Errors in the background page: missing chrome.cookies.onChanged API

Grammarly-bg.js:2158 : uncaught TypeError: Cannot read property 'onChanged' of undefined at Object.watch (Grammarly-bg.js:5992) at watchToken (Grammarly-bg.js:14594) at exports.createCookieChannel (Grammarly-bg.js:13841) at runCallEffect (Grammarly-bg.js:2224) at runEffect (Grammarly-bg.js:2191) at next (Grammarly-bg.js:2164) at proc (Grammarly-bg.js:2369) at runForkEffect (Grammarly-bg.js:2245) at runEffect (Grammarly-bg.js:2191) at Grammarly-bg.js:2300 at Array.forEach () at runParallelEffect (Grammarly-bg.js:2299) at runEffect (Grammarly-bg.js:2191) at next (Grammarly-bg.js:2164) at proc (Grammarly-bg.js:2369) at runSaga (Grammarly-bg.js:8015)

missing api : chrome.cookies.*

alexstrat commented 6 years ago

with electron 1.7.8:

Missing chrome.cookies.*

Can be added quite easily since the electron APIs exists.

Issues with locaStorage

Missing chrome.tabs.onActivated

Missing chrome.window.onFocusChanged


1-2 work days might be enough to fix this

hugomano commented 5 years ago
hugomano commented 5 years ago

ECx Status

screenshot 2019-02-01 at 16 58 09

Chrome Status

screenshot 2019-02-01 at 16 58 43

We didn't receive the user from the Grammarly server.

Next step: fin where onboarding fail.

hugomano commented 5 years ago

https://github.com/getstation/electron-chrome-extension/pull/42

hugomano commented 5 years ago

Electron

screenshot 2019-02-12 at 16 33 21

Chrome

screenshot 2019-02-12 at 16 34 01

Wavebox thread: https://github.com/wavebox/waveboxapp/issues/464

Initial settings are not initialized from the same way between Chrome and Station. The user onboarding is not triggered in the Electron version. Our version stops to works before loading an anonymous user without errors. Only one API is called in this timelapse: cookies. After verification, our cookie works well and are structured like Chrome.

The last hypothesis that I have is the popup behind the browser action (also present in Wavebox were Grammarly seems to work well from my usage). Indeed, the background may be that our background page awaits a message from the popup before start hydrating the user.

Currently waiting for news from Grammarly.

hugomano commented 5 years ago

see https://github.com/electron/electron/issues/17069

splintor commented 5 years ago

@hugomano Now that #42 is merged, can you give details about the current status of Grammarly extension support in Station? Thanks! 🙏

thoraxe commented 4 years ago

@hugomano is this closed because it's been decided this won't work?

thoraxe commented 4 years ago

OK, after some research I see that Grammarly as a dedicated app is available, however it doesn't seem to add the Grammarly checking to other apps (eg: GMail) like the traditional chrome extension does.

It's not clear from https://feedback.getstation.com/feature-requests/p/integrate-chrome-extensions-support-grammarly-todoist-zoom-hubspot-forgmail-simp whether or not that is planned.