getstation / electron-chrome-extension

Implementation of Chrome extension APIs for Electron
139 stars 26 forks source link

feat: support grammarly #42

Closed hugomano closed 5 years ago

hugomano commented 5 years ago

Objective

Support Grammarly extension

What this PR does

Acceptance tests

alexstrat commented 5 years ago

@hugomano d8c4c86 seems to have unblocked your issue.

hugomano commented 5 years ago

24/04 - 18h00

hugomano commented 5 years ago
Screenshot 2019-05-15 at 16 49 45

todo: emit correctly chrome.tabs events

hugomano commented 5 years ago

tabs.onUpdatedevents are missing

chrome.tabs.onUpdated.addListener(function(e,t){n.getActiveTab().then(function(n){n&&n.id===e&&(t.url||t.favIconUrl||"complete"===t.status)&&chrome.tabs.get(e,function(e){return o(e)})})})
hugomano commented 5 years ago

same with tabs.onActivated

alexstrat commented 5 years ago

For the record, can you detail what was broken with Port please?

hugomano commented 5 years ago

Regarding https://github.com/getstation/electron-chrome-extension/pull/42#issuecomment-498296642, the MessageSender#url embedded in the Port was missing.