search

getstation / electron-chrome-extension

Implementation of Chrome extension APIs for Electron
138 stars 26 forks source link

[App-463] preload errors leaked to renderer #57

Closed alexstrat closed 4 years ago

alexstrat commented 4 years ago

Following https://github.com/getstation/electron-chrome-extension/pull/47#discussion_r294635374 removed the unnecessary and broken polyfill for postMessage.

(broken: messageObj is already defined)

Remove some useless logs as well.

Fix a broken condition that leaked a window.opener in the renderer.

alexstrat commented 4 years ago

Published as of d466133db8af181d58829a9570931081a9eecfe0 as electron-chrome-extension@3.0.1-rc

alexstrat commented 4 years ago

Published as of ff1032ea0cf7b0c01b96b8cb7ad7d2e22d83319b as electron-chrome-extension@3.0.1-rc.2

hugomano commented 4 years ago
hugomano commented 4 years ago

LGTM!