search

getstrake / aws-pricing-sheets-addon

Google Sheets add-on for AWS Pricing
https://workspace.google.com/marketplace/app/aws_pricing_by_strake/378787760903
33 stars 0 forks source link

Add apps script manifest keys per the Google documentation. #8

Closed aryounce closed 1 year ago

aryounce commented 1 year ago

These changes have been pushed to HEAD for the Apps Script project (which is shared with @wimdenherder & @reganbrianpatrick).

The manifest has been updated with information that the Google documentation mentions as required. Once the manifest was updated it became possible to install the add-on in a test state.

See: https://developers.google.com/apps-script/add-ons/concepts/workspace-manifests

wimdenherder commented 1 year ago

Great work! Is the scope https://www.googleapis.com/auth/userinfo.profile needed for the add-on?

Besides that, only two scopes are required: "https://www.googleapis.com/auth/userinfo.email", "https://www.googleapis.com/auth/script.container.ui"

  1. UrlFetchApp does not require permissions when executed in the context of a custom function (that surprised me :))
  2. SpreadsheetApp is not used in the script (getting or setting values), only the SpreadsheetApp.getUi()
wimdenherder commented 1 year ago

I've merged this and followed up with a new pull request, in which I narrowed the scopes