getting-things-gnome / gtg

Getting Things GNOME! trunk
https://wiki.gnome.org/Apps/GTG
GNU General Public License v3.0
554 stars 166 forks source link

Tracking issue: call for translators #358

Open nekohayo opened 4 years ago

nekohayo commented 4 years ago

This is a ticket where translators can comment and tell the others that they are working on the translation for language X, Y or Z, so that other translators of that same language don't end up working on the same thing at the same time. When a translator is done with a particular language and their contribution has been merged, they should probably edit their comment, to let other onlookers know that they are done working on it.

Obviously this primitive "take the lock" system is simply meant as a temporary stop-gap measure for the fact that we don't yet have a translation system, which might be solved by migrating to GNOME's gitlab as part of issue #234.

Neui commented 4 years ago

I'd be interested to improve the german (de) translation. I'll also be happy if another german-speaking person would review the translation I would then submit. However, I've some questions:

nekohayo commented 4 years ago

How should I send in the translation? I guess via pull request(s)?

That can work yes, if you're at ease with Git; otherwise even .po files thrown at me via email is acceptable (but potentially less efficient as it makes me the bottleneck) if that makes it easier.

How do I test the translations? [...] Edit: Actually, after editing an string, gtranslator removed the fuzzy line and it works now. Maybe that is the culprit?

Yeah, assuming the English source strings do match, your translated strings must not be marked as "fuzzy" for them to show up as translated when you run LANG=de_DE.UTF8 ./launch.sh

Should I create issues to suggest improvements to the original strings?

Yeah, if you have suggestions for improvements that would be relevant to all languages, yep!

What about mnemonics? It seems the old translation still has references to some that the original english ones doesn't have, and the other way around.

Usually because the strings in question have changed / been replaced/removed. I asked myself that question recently and found myself thinking "do mnemonics really matter anyway these days, especially in the less-menu-driven UI paradigms we're in now?"...

gerazo commented 4 years ago

Thanks a lot for bringing such a nice project back to life. I would like to bring the Hungarian translation up-to-date.

By the way, is there a decision on mnemonics? Should we just remove them? (I never use them personally in the current version.)

gerazo commented 4 years ago

After finishing the translations, I've noticed that some things, mainly the firstrun_tasks.py documents are randomly not translated. I've noticed that @nekohayo made a better English version in https://github.com/getting-things-gnome/gtg/commit/0b45799e948e9a28db10db65dbf2d97b33419be3#diff-8d05f8a4dfccd08e3d5cd2052bd45aa1 which was updated trough to the .PO files, but later, @diegogangl reversed those changes in https://github.com/getting-things-gnome/gtg/commit/9134d4770f9619f75fd933aea2acab95c04751d9#diff-8d05f8a4dfccd08e3d5cd2052bd45aa1 so the code has old text while the PO files have a newer version, so IDs do not find eachother.

So I have no clue which version should be the real one which the translators need. Was the last commit of @diegogangl accidental? (There could be a CI task which checks if PO files need updating in such cases.)

diegogangl commented 4 years ago

Hi, I didn't reverse the changes. The code changed but the strings are the same. Maybe I made some mistake when porting them over? Any lines or examples of what isn't being translated?

gerazo commented 4 years ago

around line 208, title of one subtask was originally "Learn How To Use Plugins" but was changed to "Learn About Plugins". This is now the msgid also in PO files. But you changed it back to "Learn How To Use Plugins".

diegogangl commented 4 years ago

Pushed bbfff16dbfecef765103f9e12a8dbe18f6ed4b7c fixing the titles, thanks for bringing it up! I don't have more time for now, but let me know if you find more broken translations

Neui commented 4 years ago

Hi, I didn't reverse the changes. The code changed but the strings are the same. Maybe I made some mistake when porting them over? Any lines or examples of what isn't being translated?

Try using the following link: https://github.com/getting-things-gnome/gtg/commit/9134d4770f9619f75fd933aea2acab95c04751d9?w=1#diff-8d05f8a4dfccd08e3d5cd2052bd45aa1 The ?w=1 parameter skips whitespace so it makes it easier to spot text differences.

A few examples:

It seems it hasn't been "reverted" completely (like the "\"Insert Subtask\" button" in the old version, but the rewrite uses "subtask insertion button", which the lxml-commit kept)

gerazo commented 4 years ago

Thanks @diegogangl However, as @Neui pointed out, the document bodies to the fixed titles are also broken. To be precise these are broken in that file:

diegogangl commented 4 years ago

Thanks guys, this time it really is fixed :pray: . Tested against the FR translation

gerazo commented 4 years ago

@diegogangl Thank you. Everything works fine. So, here is the Hungarian translation: https://github.com/getting-things-gnome/gtg/pull/462 Should I invite someone else (an other Hungarian speaker) for the review? Or how do you usually do this?

diegogangl commented 4 years ago

Thanks for the PR! We don't have much of a translation workflow yet. It'd be great if you could invite someone to review, otherwise I can just merge it. It's not going to be worse than the outdated translation :)

nekohayo commented 2 years ago

A new .pot file has been pushed to the git version recently, for the upcoming 0.6 release, probably happening in a week or so. Now is a good time to update translations!

nekohayo commented 2 years ago

Also, if any francophone is reading this: I've already taken care of the French translation on my side, just not committed yet because I'm waiting a few days to see if anything changes with the Gamify plugin or not, but will commit my 100% translated version sometime during the week.

gerazo commented 2 years ago

@nekohayo Will you do a mass update on all .po files like you used to do before, or shall we just modify the only updated locales?

nekohayo commented 2 years ago

I think I was told previously that I should avoid touching the global .po files, and only regenerate the .pot file and letting translators update their po from it? It's a bit unclear to me, but I'm guessing that touching the individual .po files at this point would create conflicts for them.

gerazo commented 2 years ago

I believe I have finished updating the Hungarian translation in https://github.com/getting-things-gnome/gtg/pull/814 Thanks for including in advance.