Tags selector popover in the task editor should be oriented upwards to avoid overlapping the contents

nekohayo commented 4 years ago

The tag search popover obscures my view, and therefore makes it difficult/impossible to know when a tag has been successfully added to the task (unless we were to make that popover go away when selecting/adding a tag, but I'm suspecting some people might want to add multiple tags with it).

It would probably be trivial to set it to be oriented upwards instead of downwards.

diegogangl commented 4 years ago

Not so sure, you can change the direction to up in Glade but it still comes down. Maybe this would be fixed by having the toolbar in the bottom?

nekohayo commented 4 years ago

Ah, I see why now. The orientation is controlled by https://developer.gnome.org/gtk3/stable/GtkPopover.html#gtk-popover-set-position by saying GTK_POS_TOP instead of GTK_POS_BOTTOM... but it won't work because of this bit in the documentation:

This preference will be respected where possible, although on lack of space (eg. if close to the window edges), the GtkPopover may choose to appear on the opposite side.

...so GTK, or Mutter/GNOME-Shell, really really doesn't want popovers to show "outside the window" (as I would want them to in this case), it wants them to be overlaping within the confines of the parent window... which means that even putting the toolbar at the bottom wouldn't necessarily solve the problem, because then it would always be oriented "top" and would refuse to go "bottom", and would thus still overlap the contents. Or at least, it would open the big design question that is #297 ...

Alternatives I could imagine:

The popover being dismissed everytime a tag is selected/inserted, i.e. as if it was a dialog that was "acknowledged"
Setting the popover widget's opacity to 95% (0.95 instead of 1.0) so that a "little bit" of the yellow tags behind would show through, but that might be weird/ugly (it would only work well if GTK provided the ability to have a blurred semi-transparent background instead)
Have the tags in the popover presented as a list of checkboxes that can be checked on/off (whether with the mouse or the spacebar or Enter key or whatever activation signals)
Declaring this bug unsolvable

Alternatives 1 or 3 are what I'd tend to favor, because the current situation makes you wonder, as a user, if/when the tag has been inserted correctly.

diegogangl commented 4 years ago

I think option 3 would be the best workflow, though if we want to re-use the popover for autocomplete we might want to go for 1

getting-things-gnome / gtg

Tags selector popover in the task editor should be oriented upwards to avoid overlapping the contents #409