search

gettyimages / spray-swagger

Apache License 2.0
140 stars 50 forks source link

swagger-core 1.5 (Swagger Spec 2.0) support #63

Open everpeace opened 9 years ago

everpeace commented 9 years ago

I'm pleased if I would hear or discuss how spray-swagger would support/migrate to swagger-core 1.5?? I understand swagger-core 1.5 did make many changes, e.g. package structures and more flexible module structures which separates each responsibilities clearly, etc. And moreover, swagger-core 1.5 ships many enhancements(better generics support, auto subtypes generation, etc.).

It also seems that scala support is now developing in swagger-scala-module .

mhamrah commented 9 years ago

We don't have any immediate plans to do this, but we're happy to accept a pull request.

rleibman commented 9 years ago

I already put a pull request in (which also uses akka-http)

everpeace commented 9 years ago

Wow, looks great! However, I understand that swagger-core 1.5 has already been released officially but akka-http hasn't. So, I think these support will be separated.

What do you think?

rleibman commented 9 years ago

Yes everpeace... it hasn't been officially released, it's on RC4, which means it's really close. I'm working on an internal application that won't be released for a few months, so I thought I could afford to be on the bleeding edge a bit, I first worked on akka-http and then on swagger-core 1.5, I reailize that if I had done it in the opposite order it would have easier to incorporate swagger-core's latest. Hopefully the work I did shows you how it could be done.

rleibman commented 9 years ago

Spoke too soon :) Apparently akka-http was released today! At least according to this: http://doc.akka.io/docs/akka-stream-and-http-experimental/ It's still marked as experimental, but it IS out there. I just updated all my projects to it without any issues.

pjfanning commented 8 years ago

I have forked spray-swagger and have a new release pushed to sonatype. https://github.com/swagger-spray/swagger-spray - it uses the latest io.swagger jars. Hopefully, this should appear in maven central over the coming days. Thanks to the all the developers who have contributed to this project, including a few unmerged pull requests that I added in the fork.