search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
482 stars 357 forks source link

[BUG] Bluewallet: name of container in docker-compose file doesn't match with the actual name of the container #1039

Closed MisterCyp closed 3 weeks ago

MisterCyp commented 2 months ago

Hello,

I tried to install BlueWallet Lightning on my umbrel node and it never worked (installation stuck on starting process) When I investigate I discover that the hostname in the docker-compose of bluewallet doesn't match with the actual name of the container.

bluewallet/docker-compose.yml :


services:
  app_proxy:
    environment:
      APP_HOST: bluewallet_lndhub_1
      APP_PORT: 3008
      PROXY_AUTH_ADD: "false"

The name oh the container on my PC: bluewallet-lndhub-1

When I changed the name in the docker-compose.yml, it has worked.

I'm the only one having this problem ?

highghlow commented 2 months ago

This is because of a stupid change by the docker-compose team. Docker-dash-compose (v1) separates compose container names with underscores, while dockers space compose (v2) with dashes. Umbrel is currently using docker compose v1. Unfortunately it's deprecated, so they'll have to migrate at some point

highghlow commented 2 months ago

I think this marks this issue as closed. If you want to use docker-compose v1, write it with a dash.

nmfretz commented 3 weeks ago

Thanks for addressing this @highghlow 🙏.

FYI, As of umbrelOS 1.0 we are actually now using Compose V2. Even so, we force container names to the old underscore format to maintain compatibility across compose versions: https://github.com/getumbrel/umbrel/blob/aa3cdaec406315bee0a97ba7b475870de0ebfc40/packages/umbreld/source/modules/apps/app.ts#L93-L109

@MisterCyp, the issue you are running into will very likely be because you have umbrelOS 0.5.x installed on debian/ubuntu with a Docker Compose version that was not the one the umbrel bash script installs. To stay on umbrelOS 0.5.x and have everything work you should make sure you are using Docker Compose v1. Otherwise, moving to umbrelOS 1.x will solve this issue.

Closing this issue, but please reach out to us via our official support channel through our website if you need additional help: https://umbrel.com/