search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
517 stars 381 forks source link

fix: ensure ord data dir exists before touch #1041

Closed mrv777 closed 5 months ago

mrv777 commented 5 months ago

I could be missing something, but on a new install when the pre-start file runs the data directory doesn't seem created yet so the touch command fails and doesn't create that version check file

mayankchhabra commented 5 months ago

Thanks for the PR, @mrv777! The data/ord directory is committed in the repo, so we don't need to create it in the pre-start hook. I wasn't able to reproduce the touch command failing to create the version check file on a fresh install of Ordinals. Can you double-check, or help me with the steps to reproduce it?

mrv777 commented 5 months ago

Hmm, I think you could be right as maybe this only effects a custom app store. The new command: umbreld client apps.install.mutate --appId ordinals doesn't seem to give the output anymore of the install so can't confirm, but I'm guessing that is the issue on the custom app store and that its fine for the main repo maybe.

mayankchhabra commented 5 months ago

Makes sense, yeah. If you commit data/ord directory in https://github.com/mrv777/umbrel-community-app-store/tree/master/mrv777-ordinals, it should be working fine without mkdir -p. Closing the issue for now! :)