search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
482 stars 357 forks source link

Add just download #1060

Closed highghlow closed 3 weeks ago

highghlow commented 2 months ago

This time it's my own app!

App Submission

App name

Just. Download. or Just Download

256x256 SVG icon

(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.) We will help finalize this icon before the app goes live in the Umbrel App Store.

If I manually insert the icon into Umbrel's homepage, it is just a little bit too bit

https://raw.githubusercontent.com/highghlow/just-download/main/public/icon.svg

Gallery images

(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.) We will help finalize these images before the app goes live in the Umbrel App Store.

1713553024158

image

Yes, the search results are in Russian because I'm using rutracker.org as my indexer. The actual app is in english.

UPDATE: After I updated to Umbrel v1 I cannot use this app. The indexer I use requires a proxy. I used tor as a proxy, but now I cannot customize it's torrc and add bridges.

Please make it look cool!

I have tested my app on:

highghlow commented 1 month ago

The app still requires a better configuration screen, but other than that, it's functional

nmfretz commented 1 month ago

Thanks for making your own app and submitting to the official app store @highghlow! I've just played around with it.

The app still requires a better configuration screen, but other than that, it's functional

With the current app requiring users to have knowledge of the precise format to use when adding an indexer to the configuration array, do you want to launch this app as part of your own Community App Store until you've built out the UI further? Right now I could see the following flow being too difficult for the average user to figure out if they were to install Just. Download.

https://github.com/getumbrel/umbrel-apps/assets/85373263/3d563983-74c4-4aca-ad08-38bcdc7502f6

highghlow commented 1 month ago

do you want to launch this app as part of your own Community App Store until you've built out the UI further?

Okay, I'll stop procrastinating and add a proper config screen now

highghlow commented 1 month ago

Just as I said that my archlinux system died and docker imposed sanctions on my country. It took a little bit longer than I expected, but there is now a proper config menu, @nmfretz . I can't test it on my umbrel now, but I will in a few hours

highghlow commented 1 month ago

It's happening because the search results are usually returning null for results[index].description. Was this supposed to render the data from results[index].title instead?

If think I did this because jackett-rutracker returns a cut-down version of the title in title. I'll add a config option for this

highghlow commented 1 month ago

Alright, @nmfretz . Everything is now fixed

highghlow commented 1 month ago

The new "Use title as description" option is set to false on previously added indexers, but defaults to true on new ones

nmfretz commented 1 month ago

Thanks @highghlow! Okay, we shall get some gallery images made up.

highghlow commented 4 weeks ago

Yay!

nmfretz commented 3 weeks ago

Hey @highghlow - was just going through this to test on multiple architectures and finalize for submission. I noticed that the image is x86 only (https://github.com/highghlow/just-download/pkgs/container/just-download). Are you able to push a build for multi-arch amd64 and arm64 so that we make sure Raspberry Pi users can install this?

Here are the gallery assets. We'll go live as soon as we have a working multi-arch image! icon 1 2 3

highghlow commented 3 weeks ago

We'll go live as soon as we have a working multi-arch image!

Working on it

highghlow commented 3 weeks ago

Alright, it now has arm64 support!

highghlow commented 3 weeks ago

I have also just now realized that the icon is broken in the browser. I only looked at it in inkscape. Give me a second

highghlow commented 3 weeks ago

So, I don't think it's possible to bundle a font with an svg, so here are the pngs:

nmfretz commented 3 weeks ago

Thanks for the quick turnaround on the multi-arch image @highghlow! Going live to the app store now.

I have also just now realized that the icon is broken in the browser. I only looked at it in inkscape. Give me a second

Thanks for these. I'll get the icon svg tweaked with your changes and replace the existing icon when it's done.

Gallery images: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/just-download

image