getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
481 stars 356 forks source link

Add missing `releaseNotes` keys and logo fix #1109

Closed sharknoon closed 1 month ago

sharknoon commented 1 month ago

Hello,

I have found some small issues:

Kind regards

Sharknoon

nmfretz commented 1 month ago

Thanks for this PR @sharknoon! The releaseNotes key is optional in all versions of umbrelOS, but I think it is a really good idea to include it as a placeholder in every manifest like you have done here. This way it reminds people to update the release notes when the first app update goes through.

I have let our designer @surajmahraj know about the Adguard Home logo 🤝


Also, for some context on recent commits where we added the path and dependencies keys to a couple apps. These keys are optional in umbrelOS 1.x, but they actually cause problems when they are missing in umbrelOS 0.5.x so we added them in to maintain compatibility with older versions. What happens when they are missing is that the app's install screen in the app store will not render in umbrelOS 0.5.x.

sharknoon commented 1 month ago

Thank you for clarifying. I have based my linter on the schema and was confused, that it seemd to be mandatory. Looking forward to the new App Framwork to detect such errors early 😀

Thank you for reviewing this PR 👍