getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
481 stars 356 forks source link

Linter for PRs #1110

Open sharknoon opened 1 month ago

sharknoon commented 1 month ago

Hello,

I have created a small CLI tool to help developers creating new apps for Umbrel. The tool also features a linter that detects common problems such as missing keys in yml files or malformed values.

This GitHub Action uses that linter to immediately tell, if a PR passes the check or not. Here is the list, what it checks:

umbrel-app.yml:

docker-compose.yml:

[!NOTE] This is just a temporary solution as Umbrel is coming up with their own tooling for their new Umbrel App Framework soon

nmfretz commented 4 weeks ago

Really great work on this @sharknoon. Looking forward to integrating this to give people a nice way to check their submissions and to automate part of the review process 🎉

sharknoon commented 4 weeks ago

Thank you @nmfretz 😀