getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
480 stars 357 forks source link

Update PeerSwap Web UI to v1.5.7 #1170

Closed Impa10r closed 5 days ago

Impa10r commented 1 week ago

Adds channel Auto Fee functionality plus various enhancements.

image

nmfretz commented 1 week ago

Thanks for the update @Impa10r. I'm just re-syncing Elements Core to test.

nmfretz commented 6 days ago

Hey @Impa10r, I changed the environment variable NO_HTTPS from:

NO_HTTPS: true

to

NO_HTTPS: "true"

Can you please test to see that peerswap is consuming this correctly?

The reason I did this is that I noticed Docker Compose v1 and v2 treat boolean values differently:

V1 does not allow booleans for environment keys: https://docs.docker.com/compose/release-notes/#170

So users running umbrelOS 0.5.4 (which uses Compose v1.29.2) will get a broken install/update, with this error: services.web.environment.NO_HTTPS contains true, which is an invalid type, it should be a string, number, or a null

V2, however, does allow certain booleans:

umbrelOS 1.x uses Compose v2.27.1, so the original boolean value you used works fine.

Please let me know if this change works for you and then I'll merge.

nmfretz commented 5 days ago

Perfect, thanks for checking! Going live.