Closed Impa10r closed 5 days ago
Thanks for the update @Impa10r. I'm just re-syncing Elements Core to test.
Hey @Impa10r, I changed the environment variable NO_HTTPS
from:
NO_HTTPS: true
to
NO_HTTPS: "true"
Can you please test to see that peerswap is consuming this correctly?
The reason I did this is that I noticed Docker Compose v1 and v2 treat boolean
values differently:
V1 does not allow booleans for environment keys: https://docs.docker.com/compose/release-notes/#170
So users running umbrelOS 0.5.4 (which uses Compose v1.29.2) will get a broken install/update, with this error:
services.web.environment.NO_HTTPS contains true, which is an invalid type, it should be a string, number, or a null
V2, however, does allow certain booleans:
true
and false
allowed as of version 2.17.0: https://docs.docker.com/compose/release-notes/#2170umbrelOS 1.x uses Compose v2.27.1, so the original boolean value you used works fine.
Please let me know if this change works for you and then I'll merge.
Perfect, thanks for checking! Going live.
Adds channel Auto Fee functionality plus various enhancements.