getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how β†’ https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
529 stars 398 forks source link

Update nextcloud to version v30.0.0 #1547

Closed nmfretz closed 1 month ago

nmfretz commented 1 month ago

πŸ€– This is an automated pull request to update nextcloud to version v30.0.0. This PR must be reviewed and tested before merging.

nmfretz commented 1 month ago

πŸ€– This is an automated summary of installation tests for nextcloud:

This PR must still be reviewed and tested before merging.

nmfretz commented 1 month ago

This will require a rewrite of the pre-start script to properly handle migrations now that we are on v30

github-actions[bot] commented 1 month ago

πŸŽ‰   Linting finished with no errors or warnings   πŸŽ‰

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "cron":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
❌ Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.
nmfretz commented 1 month ago
dennysubke commented 1 month ago

Thanks for the update!

However, I receive a warning in my Nextcloud instance about the MariaDB version in use:

β€œFor optimal performance and stability, it is recommended to use MariaDB version > 10.6 or 11.4.” cb1295ad0e4c1ed99cddfeb7a0ff1561b1f14345

nmfretz commented 1 month ago

Thanks for noting this @dennysubke! Shall we schedule the mariadb update for Nextcloud 30.0.1 which should be out soon (https://github.com/nextcloud/server/milestone/279)?

We'll need to be careful when updating mariadb and may need to run some mariadb specific migration logic in the pre-start script when we do so (https://mariadb.com/kb/en/mariadb-upgrade/).

dennysubke commented 1 month ago

Thanks for the heads-up @nmfretz ! Scheduling the MariaDB update around the release of Nextcloud 30.0.1 sounds like a good plan.

ant0nwax commented 1 month ago

Hi, I just upgrade to Nextcloud 30.0.1 and I understand that the MariaDB upgrade from 10.3 to next useful version will be in 30.0.2 earliest and is NOT needed to be done manually.

Further I vote +1 for Maps Nextcloud App to be compatible to NC 30.

After updating I could click "Allow Untested App" and clicked "Enable". Why is it actually not compatible? Does anyone know? Maybe it is just false information. Testing it 1 minute seems to work.

dennysubke commented 1 month ago

Hi, I just upgrade to Nextcloud 30.0.1 and I understand that the MariaDB upgrade from 10.3 to next useful version will be in 30.0.2 earliest and is NOT needed to be done manually.

Further I vote +1 for Maps Nextcloud App to be compatible to NC 30.

After updating I could click "Allow Untested App" and clicked "Enable". Why is it actually not compatible? Does anyone know? Maybe it is just false information. Testing it 1 minute seems to work.

The compatibility issues with apps can sometimes be due to version constraints set by the app developers. They might mark an app as incompatible with a new version of Nextcloud until they have fully tested it. In some cases, the app might work just fine, but the developers want to avoid potential issues for users who rely on it.

dennysubke commented 4 weeks ago

@nmfretz The time has come, v30.0.1 is available: https://hub.docker.com/layers/library/nextcloud/30.0.1-apache/images/sha256-a4e0f2c053010cc391fd63040779553ff2a266ea52c1e37555f0a967eb466ec3?context=explore