search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
516 stars 381 forks source link

Update default `docker-compose.yml` #1549

Closed Zoobdude closed 4 days ago

Zoobdude commented 5 days ago

the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion

Reference in the compose-spec

github-actions[bot] commented 5 days ago

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

nmfretz commented 4 days ago

Thanks for noticing this @Zoobdude and for submitting a fix!

We are in the process of re-doing our app ecosystem on umbrelOS, which will include bringing compose files up to spec.

In the meantime though, we need to keep this legacy version attribute as-is for compatibility with umbrelOS 0.5 which is using a version of Compose that requires it (this version also requires that our app_proxy compose file and the app's main compose file have the exact same version or Compose will error out). Both umbrelOS 0.5 and 1.x use this repo, so removing or not including the version attribute would break all umbrelOS 0.5 instances.

Closing this issue, noting that we are aware of the spec. Thanks again for the sharp eyes.