search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
529 stars 398 forks source link

Update homebridge to 2024-09-03 #1554

Closed JoseMoranUrena523 closed 1 month ago

JoseMoranUrena523 commented 1 month ago

This is a pull request to update homebridge to version 2024-09-03. PR must be reviewed and tested before merging.

nmfretz commented 1 month ago

Thanks for this PR @JoseMoranUrena523! Good catch on the newer Docker image. Homebridge docker tags are released on a different schedule than the main homebridge release which leads to some confusion. For instance...

The previous image tag "2024-06-27" shows homebridge as already being on 1.8.4

image image

Which strangely doesn't match up with homebridge's release documentation which shows that Docker tag as including v1.8.3: https://github.com/homebridge/docker-homebridge/releases

What I've done is kept the version as 1.8.4 in the app store with the suffix -ui-update. This change to the manifest means that users will get notified of an update while still seeing that Homebridge is 1.8.4.

I added release notes explaining that this release updates the Homebridge UI (v4.56.4 --> v4.57.1)

Tested and going live.

github-actions[bot] commented 1 month ago

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ homebridge/docker-compose.yml Potentially using unsafe user in service "server":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ homebridge/docker-compose.yml Service "server" uses host network mode:
The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.

Legend

Symbol Description
❌ Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.
JoseMoranUrena523 commented 1 month ago

Hello @nmfretz! You’re welcome on the PR. Do you know when issues and pull requests on getumbrel/umbrel will be reviewed as well as job applications?