search

getumbrel / umbrel-apps

The official app repository of the Umbrel App Store. Submit apps and updates here. Learn how → https://github.com/getumbrel/umbrel-apps#readme
https://apps.umbrel.com
530 stars 396 forks source link

Bump monerod version to v0.18.3.4 #1808

Closed colder-is-better closed 6 days ago

nmfretz commented 6 days ago

Thanks for this update @colder-is-better! Sorry for the delay in reviewing this while we had our heads down on the recent umbrelOS beta release.

FYI, the monerod service must have a restart policy of "unless-stopped" in order for the daemon to start back up automatically when it is "restarted" from the UI in Advanced Settings. Without this, when a user goes to change their monero config in Advanced Settings and clicks "Save and restart monero node", their node would not actually come back online. I have changed it back here https://github.com/getumbrel/umbrel-apps/pull/1808/commits/74964e88d62f9a7c3e4cc26bf09427509f5ec01d.

I have tested a fresh install and update and everything is working well. I also added some release notes:

image
colder-is-better commented 6 days ago

Thanks for this update @colder-is-better! Sorry for the delay in reviewing this while we had our heads down on the recent umbrelOS beta release.

Hey, no problem -- that was a quick review on my book!

FYI, the monerod service must have a restart policy of "unless-stopped" in order for the daemon to start back up automatically when it is "restarted" from the UI in Advanced Settings. Without this, when a user goes to change their monero config in Advanced Settings and clicks "Save and restart monero node", their node would not actually come back online. I have changed it back here 74964e8.

I already managed to bump into this issue, and I was scratching my head trying to figure out what happened. Thanks for fixing and clarifying this!

I have tested a fresh install and update and everything is working well. I also added some release notes:

Very nice. From now on, I'll be sure to add those myself.