getumbrel / umbrel-bitcoin

The official Bitcoin Node app for Umbrel, powered by Bitcoin Core.
https://umbrel.com
Other
34 stars 18 forks source link

Expose maxuploadtarget via settings #14

Closed Synesso closed 8 months ago

Synesso commented 3 years ago

For users in low to moderate bandwidth settings, it is important to be able to modify how much data is uploaded by the node. The default setting is to upload as hard as it can.

Currently the only approach for reconfiguring this behaviour is to ssh onto the host and edit bitcoin.conf directly.

When Umbrel receives an update, this setting is overridden and the process has to be repeated.

It may be ideal to expose this setting via the Umbrel settings page and persist it across updates.

kroese commented 1 year ago

The problem is that when you set the target very low, it will prevent Electrs from indexing, as it downloads the block via a p2p connection and will hit the limit pretty quickly.

I submitted a patch https://github.com/getumbrel/umbrel-bitcoin/pull/10 to fix this, so ideally it will be merged before this change.

nmfretz commented 8 months ago

Thanks @Synesso and @kroese. maxuploadtarget has now been added to advanced settings here https://github.com/getumbrel/umbrel-bitcoin/commit/b9f67e7b68e39baa14389593f0b405a8d7b0de63. In 0.5.0 you can find

And Kroese's patch for whitelisting electrs has been added here https://github.com/getumbrel/umbrel-bitcoin/commit/4030c212a4a97778eeb47a3c7a8434b7ec64261a

You can find maxuploadtarget under the "Peer Settings" category:

image