search

getumbrel / umbrel-dashboard

[Deprecated] Moved to https://github.com/getumbrel/umbrel/tree/master/packages/dashboard. Web-based dashboard to interact with your Umbrel.
https://github.com/getumbrel/umbrel/tree/master/packages/dashboard
Other
132 stars 69 forks source link

Add Trezor Suite connection details #413

Open sime opened 2 years ago

sime commented 2 years ago

The recent release of Trezor Suite include Electrum server support..

louneskmt commented 2 years ago

Btw, it looks like the use of a custom Electrum server is not available for testnet (I wanted to review this PR on my testnet instance). It really isn't a big deal, just wondering why, as it is basically the same thing than for mainnet.

tsusanka commented 2 years ago

Btw, it looks like the use of a custom Electrum server is not available for testnet (I wanted to review this PR on my testnet instance). It really isn't a big deal, just wondering why, as it is basically the same thing than for mainnet.

It was more of an oversight. Definitely smth we want: https://github.com/trezor/trezor-suite/issues/5005.

sime commented 2 years ago

@louneskmt Thanks for the thorough review.

Though, I was a little trigger-happy with the TOR suggestions. Enabling TOR on Trezor Suite is simply a toggle, no need to instal anything else. Are you sure we need the TOR modal?

louneskmt commented 2 years ago

You mean there is a Tor instance built in Trezor Suite?

sime commented 2 years ago

@louneskmt Yes exactly.

louneskmt commented 2 years ago

Oh okay, so Trezor Suite starts its own Tor instance and uses it, unless the user specify a custom proxy address?

image

If so, I misunderstood the configuration. I thought it was trying to connect by default to an existing instance on 127.0.0.1:9050 ("You can configure the address to point to a different Tor instance. Default: 127.0.0.1:9050.").

louneskmt commented 2 years ago

That's great then, good job guys! My mistake, you can revert the commits related to the Tor modal and Tor first step.

louneskmt commented 2 years ago

Looks like it doesn't connect, while it is working in Sparrow. I've tried with both running my usual Tor instance and stopping it to let Trezor Suite run it.

image image

sime commented 2 years ago

@louneskmt I pushed changes which removed the TOR setup steps.

Regarding you connecting from suite: Could you try again, please? I just tested Trezor Suite with Umbrel 0.4.17. It didn't work initially, but it eventually connected.

sime commented 2 years ago

You might be experiencing this bug: https://github.com/trezor/trezor-suite/issues/5140

louneskmt commented 2 years ago

Maybe it comes from the fact that I don't have a Trezor configured with Suite?

louneskmt commented 2 years ago

You might be experiencing this bug: trezor/trezor-suite#5140

There should definitely be a "Test connection" button (like on Sparrow), or something like that.

sime commented 2 years ago

@louneskmt Yes, it's currently not possible to 'test' the connection without a Trezor connected.

louneskmt commented 2 years ago

Aaah that's why. I guess I just gonna approve this then, the PR looks good 👌

tsusanka commented 2 years ago

Ping. Could we get this released? :)