search

getumbrel / umbrel-dashboard

[Deprecated] Moved to https://github.com/getumbrel/umbrel/tree/master/packages/dashboard. Web-based dashboard to interact with your Umbrel.
https://github.com/getumbrel/umbrel/tree/master/packages/dashboard
Other
133 stars 69 forks source link

Use window.location.origin to create InstalledApp url #427

Closed b-ryan closed 2 years ago

b-ryan commented 2 years ago

Previously, the code used http://${window.location.hostname} to build the base URL for checking the status of an app. Now it uses ${window.location.origin}.

In my case, I have set up nginx as a reverse proxy in order to use TLS encryption for my node. I am accessing Umbrel via https:// now. As a result, the functionality to check the status of services was not working due to the browser blocking mixed content requests.

I have not actually tested this code, as I don't have a development environment set up for Umbrel. I'm hoping someone else can test or this is straightforward enough to include.

b-ryan commented 2 years ago

I got this project running locally to test and this change is working as expected.

lukechilds commented 2 years ago

@b-ryan good catch and thanks for submitting a PR! Would you be able to just confirm my amendments still resolve your issue? If so this is good to merge!

b-ryan commented 2 years ago

What you said makes sense, glad you caught that. This does indeed still resolve my issue, thanks!

lukechilds commented 2 years ago

Awesome, thanks @b-ryan!