search

getumbrel / umbrel-dashboard

[Deprecated] Moved to https://github.com/getumbrel/umbrel/tree/master/packages/dashboard. Web-based dashboard to interact with your Umbrel.
https://github.com/getumbrel/umbrel/tree/master/packages/dashboard
Other
133 stars 69 forks source link

Dashboard should not refer to github for images #443

Open oren-z0 opened 1 year ago

oren-z0 commented 1 year ago

The dashboard should not refer to github for images (i.e. when viewing apps in the app-store, before installing them). It's ok if the node backend will download the images on demand, but using an <img src="..." /> allows github to link the browser's ip to the umbrel apps that the user looks at.

This is especially true for users that use Tailscale and think that they are completely safe - only the requests to their node go through the VPN, not the requests to the other resources.

Obviously you can't enforce this on every app that the user installs, but this is no longer under your control.