getumbrel / umbrel-lightning

The official Lightning Node app for Umbrel, powered by LND.
https://umbrel.com
Other
16 stars 8 forks source link

change port 8080 for lnd #18

Closed thefeli73 closed 11 months ago

thefeli73 commented 3 years ago

port 8080 is commonly used by other software. This can easily changed in the configure script (as i have done in the past) but updating Umbrel seems to reset this and write the 8080 port everywhere making it extremely annoying to fix. I suggest chaning the port from 8080 -> 8448 or something that just isn't used as frequently

dugwood commented 3 years ago

@thefeli73 you can edit .env which will override the port. But I think you're right, and as NGINX_PORT that can be specified on the command line, it could be useful to allow 8080 to be changed.

Line to be changed: https://github.com/getumbrel/umbrel/blob/b2c034c95ed7cbcdc378955cdd0eee63a74eca3d/scripts/configure#L121 using the same syntax as: https://github.com/getumbrel/umbrel/blob/b2c034c95ed7cbcdc378955cdd0eee63a74eca3d/scripts/configure#L108

jimbrend commented 11 months ago

We have a workaround to change upon a first installation... or something along those lines... aware on this one and will keep top of mind going forward... Closing for now