getumbrel / umbrel-lightning

The official Lightning Node app for Umbrel, powered by LND.
https://umbrel.com
Other
16 stars 8 forks source link

Rename Lightning address to avoid confusion with LNURL Lightning Addresses #3

Closed fanismichalakis closed 2 years ago

fanismichalakis commented 2 years ago

The node address is currently referred to as "Lightning address" in the UI of the Lightning app, which may cause confusion with LNURL-based Lightning Addresses. Although the name "Lightning address" was in use in Umbrel's dashboard before the LNURL LN addresses caught traction, their usage is now quite widespread, and the term "Lightning Address" is strongly associated with LNURL Lightning Addresses.

The worst case scenario is a newcomer thinking their node address is a LNURL Lightning Address and pasting it on Twitter or Reddit, thus potentially harming their privacy as it would tie their UTXOs to their social media account.

The best name remains up to discussion. I think something like "Node Address" works very well, as it is already clear from context that it is Lightning related stuff. Just "Address" (as in Amboss) works too.

mayankchhabra commented 2 years ago

Thanks for the great suggestion. Totally agree with the reasoning. We'll rename it to "Node ID" in the next update.

mayankchhabra commented 2 years ago

Done in yesterday's release. :) Thanks @fanismichalakis!