getumbrel / umbrel-middleware

RESTful Bitcoin and Lightning API for Umbrel
MIT License
21 stars 11 forks source link

Paginated blocks (array) endpoint #17

Closed mayankchhabra closed 4 years ago

mayankchhabra commented 4 years ago

Closes #16 when finished

mayankchhabra commented 4 years ago

Please test this @nolim1t

GET /v1/bitcoind/info/blocks?from=<block height>&to=<block height>

Should return the array of blocks

nolim1t commented 4 years ago

Also did some other checks around that area

nolim1t commented 4 years ago

I just pushed a beta tag to dockerhub through the action

0.0.6-beta1

nolim1t commented 4 years ago

Sorry it is 0.0.6.1 as the -beta1 failed the initial version regex check

mayankchhabra commented 4 years ago

Deployed v0.0.6.1 on testnet server and it doesn't seem to have this new endpoint (throws 404). Are you sure it's got the latest code?

nolim1t commented 4 years ago

Yep you are correct I tagged it wrong

nolim1t commented 4 years ago

Try 0.0.6.2 in a few mins

nolim1t commented 4 years ago

latest should also work too

mayankchhabra commented 4 years ago

Yep, now it works! Perfect, merging this