search

getumbrel / umbrel-middleware

RESTful Bitcoin and Lightning API for Umbrel
MIT License
21 stars 11 forks source link

JWT Auth #19

Closed mayankchhabra closed 4 years ago

mayankchhabra commented 4 years ago

Enables JWT-based auth on all sensitive endpoints. With this, we are ready for a 0.1 release 🚀

nolim1t commented 4 years ago

Hi,

Can you please tag the tip of your branch with 0.0.6.3 (yes I know that version number) and push that tag. It will push to docker hub and build, when you feel its more ready to be tested with docker

Eventually I'll make it build push an image for PRs too. Next stage is for master builds to be pushed without tags.

mayankchhabra commented 4 years ago

Nice. I'll do that. Let's do 0.1.0.1 as it's going to be a 0.1.0 release for middleware

mayankchhabra commented 4 years ago

Done: https://hub.docker.com/layers/getumbrel/middleware/v0.1.0.1/images/sha256-5507bd2ba20045ddb0de8029a303ca3593fcaec50c65afd946f410099ab8419a?context=repo

But don't try it out now as it requires umbrel-manager to do auth, otherwise the API won't work. I'm updating all containers now

nolim1t commented 4 years ago

I put all the changes from the tip in #21

nolim1t commented 4 years ago

you may push to #21 instead

nolim1t commented 4 years ago

21 along with any checks supercedes this.

mayankchhabra commented 4 years ago

Great, closing this then