search

getumbrel / umbrel-middleware

RESTful Bitcoin and Lightning API for Umbrel
MIT License
21 stars 11 forks source link

Add in checks for docker-compose #21

Closed nolim1t closed 4 years ago

nolim1t commented 4 years ago

Need to resolve some of the issues in https://github.com/getumbrel/umbrel-compose/pull/12

mayankchhabra commented 4 years ago

If we're using .sh script, isn't it better to do the check natively via shell and skip using node entirely? We can then implement something like this https://github.com/vishnubob/wait-for-it/

nolim1t commented 4 years ago

Do you think this will resolve #19 .. yes Im using bash because node has some issues

mayankchhabra commented 4 years ago

20 you mean? Yes it will definitely fix it 😍

nolim1t commented 4 years ago

cool.. I've linked it then

mayankchhabra commented 4 years ago

Great. Do you think adding a timeout, of let's say 30s, would be a good idea? So that in case manager fails for some reason, the middleware isn't stuck in an infinite loop

nolim1t commented 4 years ago

sure

nolim1t commented 4 years ago

I'm putting all of #19 in this PR too

nolim1t commented 4 years ago

pushing to getumbrel/middleware:v0.1.0.5 (will keep reusing this)

mayankchhabra commented 4 years ago

Fantastic! paste (2)

mayankchhabra commented 4 years ago

Since there are incompatible changes (now middleware won't work without manager), let's merge this once once umbrel-manager 0.1.0 is released (i.e. https://github.com/getumbrel/umbrel-manager/pull/1 is merged).