search

getumbrel / umbrel-middleware

RESTful Bitcoin and Lightning API for Umbrel
MIT License
21 stars 11 forks source link

Use official docker buildx setup #66

Closed AaronDewes closed 4 years ago

AaronDewes commented 4 years ago

This was created by docker in cooperation with the person that created the original action.

AaronDewes commented 4 years ago

Example run (modified to skip uploading): https://github.com/AaronDewes/umbrel-middleware/runs/1108755849

lukechilds commented 4 years ago

Looks good @AaronDewes. Do you know the reason we weren't using the official action to begin with? Did it not support QEMU before?

CC @mayankchhabra do you know?

nolim1t commented 4 years ago

the initial setup was mine when it was still very new, and I followed a guide for it at the time.

nolim1t commented 4 years ago

I have no issues with switching the the docker version which is more supported

nolim1t commented 4 years ago

Unless theres a requirement to build on arm6 then you can switch.. the difference is the official doesn't build on arm6 anymore

lukechilds commented 4 years ago

Got it, thanks @nolim1t.

mayankchhabra commented 4 years ago

Sweet, didn't realize that docker had their official buildx action. Good job, @AaronDewes!

nolim1t commented 4 years ago

Yes its by the guy who did the original GH action

AaronDewes commented 4 years ago

It was not that you didn't realize it, but when the action was added, the official one didn't exist, docker created it 29 days ago.