search

getumbrel / umbrel-middleware

RESTful Bitcoin and Lightning API for Umbrel
MIT License
21 stars 11 forks source link

Add more robust check for locked wallet #88

Closed JVillella closed 3 months ago

JVillella commented 3 years ago

I've been testing the latest LND w/ Umbra and have found it is doesn't try to unlock the wallet due to a faulty is locked check. This should be more robust from looking at the LND code.

JVillella commented 3 years ago

Yep, been running locally for a few days now.

lukechilds commented 3 years ago

Thanks so much for this @JVillell!

So this isn't an immediate issue but will effect LND v0.13.0 once released, right?

JVillella commented 3 years ago

It's a fix needed for LND 0.13, that's right - but it's backwards compatible.

JVillella commented 3 years ago
  1. I would recommend backwards compatibility. Not everyone is going to update their lnd docker node in their compose file.
  2. Nice to know they have a new service; I was following their approach internally but looks like there are better ways to do this now. I won't have time to make these changes, so feel free to replace this PR or add to it with what's required.
AaronDewes commented 3 years ago

Not everyone is going to update their lnd docker node in their compose file.

To not do that, they would need to fork/modify Umbrel, which Umbrel doesn't need to care about in my opinion.