search

getumbrel / umbrel-os

umbrelOS for Raspberry Pi 4 (only). Covert your Raspberry Pi into a home server in one click. For other hardware, checkout https://github.com/getumbrel/umbrel
https://umbrel.com
BSD 3-Clause "New" or "Revised" License
590 stars 55 forks source link

Add bash aliases for commonly-expected executables running inside Docker containers #124

Closed vindard closed 3 years ago

vindard commented 4 years ago

A useful abstraction for RPi installs could be to bash alias commonly-expected commands like lncli to the location where they're currently accessible (docker exec -it lnd lncli). Executables people usually try to get at are:

image

nolim1t commented 4 years ago

maybe put them in /usr/local/bin ?

vindard commented 4 years ago

maybe put them in /usr/local/bin ?

It looks like @lukechilds already did this in an older PR (:raised_hands:) and it's just to export that PATH variable automatically when umbrel-os is being installed if we wanted.

@mayankchhabra was suggesting to add it to this file in the repo I think. Would it be as simple as adding a new PATH="$PATH:$HOME/umbrel/bin" line there, and is that something that we'd want to do? I'm thinking if someone has found their way through SSH to the terminal already then they're probably fairly technical and it's ok for them to have easier access by default to those binaries :thinking:

AaronDewes commented 4 years ago

Would it be as simple as adding a new PATH="$PATH:$HOME/umbrel/bin" line there

Yes, /etc/profile runs source /etc/default/umbrel, and if this is added to /etc/default/umbrel, it should be directly accessible.

and is that something that we'd want to do?

@mayankchhabra and @lukechilds need to decide that.

mayankchhabra commented 3 years ago

Closing this since we decided to not add the path to discourage manual CLI use (https://github.com/getumbrel/umbrel/pull/161#issuecomment-676102234) as the binary proxies were added primarily for debugging.